feat: add Codex-authored maintainer decision packets#358
Conversation
|
Codex review: needs changes before merge. Reviewed July 5, 2026, 3:41 AM ET / 07:41 UTC. Summary Reproducibility: yes. source-reproducible for the PR finding: the added malformed Review metrics: 3 noteworthy metrics.
Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Risk before merge
Maintainer options:
Copy recommended automerge instructionNext step before merge
Security Review findings
Review detailsBest possible solution: Persist terminal skip bookkeeping for malformed maintainer decisions, then land the packet contract once maintainers accept the generated-state schema and latest checks pass. Do we have a high-confidence way to reproduce the issue? Yes, source-reproducible for the PR finding: the added malformed Is this the best way to solve the issue? No, not quite; the feature shape is coherent, but malformed intent should still persist terminal skip bookkeeping so apply scans do not keep reprocessing the same bad report. Full review comments:
Overall correctness: patch is incorrect AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against def41b3f889a. Label changesLabel changes:
Label justifications:
Evidence reviewedAcceptance criteria:
What I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
Review history (1 earlier review cycle)
|
62f755a to
6763870
Compare
6763870 to
347418d
Compare
|
@clawsweeper re-review |
|
🦞🧹 I asked ClawSweeper to review this item again. |
347418d to
ce6591d
Compare
ce6591d to
927668a
Compare
Summary
This keeps the useful persistence and maintainer-facing work from @brokemac79's proposal while moving the judgment to the model, where intent is understood best. Contributor authorship remains in the commit history and the changelog thanks @brokemac79.
Safety contract
maintainerDecisionis required in the strict Codex output schema. A required decision must contain 1-3 options, exactly one recommendation, and an owner selected exactly from the proposed owner list. Missing or malformed intent fails closed before any GitHub mutation. Non-required decisions must use the canonical empty shape, so deterministic code cannot manufacture a decision from prose or labels.Proof
pnpm run check, including 668 core tests, 617 repair tests, repository coverage, lint, build, and formattinggpt-5.5; generated output accepted by the runtime parserPolicy
VISION.mdnow records the durable rule: models propose maintainer decisions; deterministic code validates, persists, refreshes, and safely enforces them.